Skip to content

[win][ci] Update LLVM toolchain used to build LLVM to 20 #140757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 20, 2025
Merged

[win][ci] Update LLVM toolchain used to build LLVM to 20 #140757

merged 1 commit into from
May 20, 2025
+2 −2

Conversation

dpaoliello
Copy link
Contributor

@dpaoliello dpaoliello commented May 7, 2025 •
edited by Kobzol
Loading

While trying to get the aarch64-msvc build working correctly (#140136), I needed to update the version of LLVM used to build LLVM in Windows CI runners to 20 (as this has improved support for Arm64 and Arm64EC on Windows).

This catches Windows up to Linux which was updated to 20 by #137189

try-job: x86_64-apple-*
try-job: aarch64-apple
try-job: x86_64-msvc-*
try-job: i686-msvc-*
try-job: x86_64-mingw-*

@rustbot
Copy link
Collaborator

rustbot commented May 7, 2025

r? @jdno

rustbot has assigned @jdno.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels May 7, 2025
@Kobzol
Copy link
Contributor

Kobzol commented May 7, 2025

The new LLVM version will need to be mirrored, see https://github.com/rust-lang/ci-mirrors.

@dpaoliello
Copy link
Contributor Author

The new LLVM version will need to be mirrored, see https://github.com/rust-lang/ci-mirrors.

Already done and merged: rust-lang/ci-mirrors#11

@Kobzol
Copy link
Contributor

Kobzol commented May 7, 2025

Oh, you're fast 😆 I forgot about that. Great.

@dpaoliello
Copy link
Contributor Author

@Kobzol @nikic did one of you two want to review this PR?

@Kobzol
Copy link
Contributor

Kobzol commented May 20, 2025

Let's run a bunch of try jobs to see if tests pass.

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request May 20, 2025
@bors
Auto merge of rust-lang#140757 - dpaoliello:llvm20, r=<try>
6c5050e 
[win][ci] Update LLVM toolchain used to build LLVM to 20

While trying to get the aarch64-msvc build working correctly (rust-lang#140136), I needed to update the version of LLVM used to build LLVM in Windows CI runners to 20 (as this has improved support for Arm64 and Arm64EC on Windows).

This catches Windows up to Linux which was updated to 20 by rust-lang#137189

try-job: `x86_64-apple-*`
try-job: `aarch64-apple`
try-job: `x86_64-msvc-*`
try-job: `i686-msvc-*`
try-job: `x86_64-mingw-*`
@bors
Copy link
Collaborator

bors commented May 20, 2025

⌛ Trying commit 036b5fc with merge 6c5050e...

@bors
Copy link
Collaborator

bors commented May 20, 2025

☀️ Try build successful - checks-actions
Build commit: 6c5050e (6c5050ea3bdfcf5b326de3b0f38737e1b685d267)

@Kobzol
Copy link
Contributor

Kobzol commented May 20, 2025

Looks fine. Let's see.

@bors r+ rollup=never

@bors
Copy link
Collaborator

bors commented May 20, 2025

📌 Commit 036b5fc has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 20, 2025
@bors
Copy link
Collaborator

bors commented May 20, 2025

⌛ Testing commit 036b5fc with merge bc82152...

@bors
Copy link
Collaborator

bors commented May 20, 2025

☀️ Test successful - checks-actions
Approved by: Kobzol
Pushing bc82152 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 20, 2025
@bors bors merged commit bc82152 into rust-lang:master May 20, 2025
7 checks passed
@rustbot rustbot added this to the 1.89.0 milestone May 20, 2025
@dpaoliello dpaoliello deleted the llvm20 branch May 20, 2025 23:18
@github-actions GitHub Actions
Copy link

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 444a627 (parent) -> bc82152 (this PR)

Test differences

No test diffs found

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard bc821528634632b4ff8dee5ac1ea4ad90d1b3eb5 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-x86_64-msvc: 6090.6s -> 11510.6s (89.0%)
  2. dist-i686-msvc: 6854.5s -> 10404.4s (51.8%)
  3. dist-aarch64-msvc: 8589.9s -> 12871.8s (49.8%)
  4. x86_64-apple-1: 12521.2s -> 9174.6s (-26.7%)
  5. aarch64-apple: 5031.7s -> 6278.3s (24.8%)
  6. dist-x86_64-apple: 11324.6s -> 9103.4s (-19.6%)
  7. x86_64-apple-2: 4867.3s -> 3937.9s (-19.1%)
  8. dist-armhf-linux: 6106.2s -> 5297.5s (-13.2%)
  9. dist-i686-linux: 6626.8s -> 5963.5s (-10.0%)
  10. dist-apple-various: 8196.7s -> 7400.6s (-9.7%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdno jdno

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.89.0
Development

Successfully merging this pull request may close these issues.
5 participants
@dpaoliello @rustbot @Kobzol @bors @jdno